So i've managed to get this working 🙂
To get more information about why portal was seeing an error I had to remove the custom error page. After that I got the .net yellow screen of death (YSOD) which lead me to a certificate error, and a validation error which required me to make the F5 metadata xml file available to download.
https://docs.microsoft.com/en-us/dynamics365/customer-engagement/portals/view-portal-error-log
Just in case anyone else tries this, these are the values for the site settings
Authentication/SAML2/F5/AssertionConsumerServiceUrl - https://{yourportalURL}/signin-saml2
Authentication/SAML2/F5/AuthenticationType - The Local IdP Service EntityID on the F5
Authentication/SAML2/F5/Caption - A label that will be applied to a button on the signin page
Authentication/SAML2/F5/MetadataAddress - The Local IdP Service metadata file in a downloadable location
Authentication/SAML2/F5/ServiceProviderRealm - https://{yourportalURL}/
Cheers,
Simon