How can I get the X-Forwarded-For IP to show up in APM Reports?

Hello, You right we can optimise this Irule, try this:

when HTTP_REQUEST {

if { [HTTP::cookie exists MRHSession] and [HTTP::cookie exists LastMRH_Session] } {
       set apm_cookie [HTTP::cookie MRHSession]
       if { (![ACCESS::session exists -sid $apm_cookie]) or ([ACCESS::session exists -sid $apm_cookie] and [ACCESS::session data get -sid $apm_cookie session.policy.result] == "in_progress" ) or ([ACCESS::session exists -sid $apm_cookie] and [ACCESS::session data get -sid $apm_cookie session.policy.result] == "not_started" ) } {

        if {[HTTP::header exists X-Forwarded-For]}{
            set userip [HTTP::header X-Forwarded-For]
            ACCESS::session data set session.user.clientip $userip
        }

       }
    }
}

you can also test this irula by removing this condition:

(![ACCESS::session exists -sid $apm_cookie])

Let me now it it's work for you or if you need explanation about this irule

regards