ProxyPass V10 iRule issues...

Posted By Opher Shachar on 02/03/2012 03:10 PM

 

Hi Gavin,

 

After a first review I have some comments:

 

> What is the purpose or intent of the additional if on line 266 ?

 

> On line 136 you changed an error level log to debug level. Why?

 

> You look for the data-group in the /Common/ partition (and path) irrespective of the path of the VS.

 

> I do find that your method of determining the correct protocol -- http / https -- is more exact. I just checked whether a SSL-client-profile was attached to the VS.

 

 

Cheers,

 

 

 

Opher

 

 

Line 266 was discussed a bit more here (http://devcentral.f5.com/Community/...fault.aspx). Basically, I spotted that the Stream profiles were being enabled even when the Client and Server side paths were identical...

 

 

 

I think the change on 136 was purely to make it match the log entry at 140... However agree that it may make more sense to have this logging at an error level.

 

 

 

Agreed, currently we're only using the /Common/ partition... However can see why it makes sense to make the rule as future proof as possible...

 

 

 

Thanks for comments on connection protocol...

 

 

 

I guess it's also worth pointing out the 'Default' redirect functionality I've added on lines 151-153. This works off of a separate DataGroup which provides a 'if you dont match something, try this.'

 

 

 

Will work your changes into my rule and see what it comes out like :)

 

 

 

Cheers

 

Gavin