External Monitor Causing CPU to Spike

Hi Ameet,

 

 

That looks pretty good. I don't see a lot that can be made much more efficient. Here are a few suggestions:

 

 

- comment out the TIME calculations if you're not debugging the monitor.

 

 

- consider not checking the current state before enabling/disabling the pool member--just enable/disable it

 

 

- replace the echoes with direct assignments:

 

 

NODE_PORT=`echo $2`

 

POOL_NAME=`echo $3`

 

POOL_NAME=`echo all`

 

 

NODE_PORT=$2

 

POOL_NAME=$3

 

POOL_NAME="all"

 

 

And after anything is sent to standard output, the script is killed. So I don't think the removal of the pidfile will ever happen. You could add a removal above the echo $output statement.

 

 

Aaron