Nested Loop for IRules Redirects

Would anyone be willing to review this and see if it can be made more efficient or has obvious errors? I converted a .htaccess file to irules and learned I was much over the maximum character limit. I’m now trying to programmatically capture the same logic. At the same time I am finding there isn’t a good way to test these except live.

<span>when HTTP_REQUEST {</span><br><br><span>#Start Sorting By Season First</span><br><br><span> set ::season_list [</span><span>fall</span><span>* </span><span>spring</span><span>* </span><span>summer</span><span>* </span><span>winter</span><span>*]</span><br><br><span> set ::term_list [</span><span>100</span> <span>101</span> <span>102</span><span>]</span><br><br><span> set ::professor_list [</span><span>smith</span> <span>jones</span> <span>smith</span><span>-</span><span>jones</span> <span>chaplain</span><span>]</span><br><br><span># Loop through the datagroup line by line.</span><br><br><span>foreach</span><span> season $::season_list {</span><br><br><span># Log the current line.</span><br><br><span> log local0. </span><span>"Current \</span><span>$season</span><span>: </span><span>$season</span><span>"</span><br><br><span># Compare the element against the string.</span><br><br><span># If the datagroup entry has a wildcard, it should be listed first in the string compare statement.</span><br><br><span>if</span><span> {[</span><span>HTTP</span><span>::</span><span>uri</span><span>] starts_with </span><span>$season</span><span>} then {</span><br><br><span># Found a match, so log it and break out of the foreach loop.</span><br><br><span>foreach</span><span> term $::term_list {</span><br><br><span># Log the current line.</span><br><br><span> log local0. </span><span>"Current \</span><span>$term</span><span>: </span><span>$term</span><span>"</span><br><br><span># Compare the element against the string.</span><br><br><span># If the datagroup entry has a wildcard, it should be listed first in the string compare statement.</span><br><br><span>if</span><span> {[</span><span>HTTP</span><span>::</span><span>uri</span><span>] contains </span><span>$term</span><span>} then {</span><br><br><span># Found a match, so log it and break out of the foreach loop.</span><br><br><span>foreach</span><span> professor $::professor_list {</span><br><br><span># Log the current line.</span><br><br><span> log local0. </span><span>"Current \</span><span>$professor</span><span>: </span><span>$professor</span><span>"</span><br><br><span># Compare the element against the string.</span><br><br><span># If the datagroup entry has a wildcard, it should be listed first in the string compare statement.</span><br><br><span>if</span><span> {[</span><span>HTTP</span><span>::</span><span>uri</span><span>] contains </span><span>$professor</span><span>} then {</span><br><br><span># Found a match, so log it and break out of the foreach loop.</span><br><br><br><br><br><span>if</span><span> {[</span><span>HTTP</span><span>::</span><span>uri</span><span>] ends_with </span><span>".html"</span><span>} then {</span><br><br><span> HTTP::respond </span><span>301</span><span> Location </span><span>"https://[HTTP::host]/archive/substr[HTTP::uri] 5].pdf"</span><span> content </span><span>""</span><span> noserver </span><span>return</span><br><br><span> }</span><br><br><span>if</span><span> {[</span><span>HTTP</span><span>::</span><span>uri</span><span>] ends_with </span><span>".htm"</span><span>} then {</span><br><br><span> HTTP::respond </span><span>301</span><span> Location </span><span>"https://[HTTP::host]/archive/substr[HTTP::uri] 4].pdf"</span><span> content </span><span>""</span><span> noserver </span><span>return</span><br><br><span> }</span><br><br><span> }</span><br><br><span>else</span><span>{</span><br><br><span> HHTTP::respond </span><span>301</span><span> Location </span><span>"https://[HTTP::host]/archive/index.php"</span><span> content </span><span>""</span><span> noserver </span><span>return</span><br><br><span> }</span><br><br><br><br><br><span> log local0. </span><span>"Matched \</span><span>$professor</span><span>: </span><span>$professor</span><span>. Exiting loop."</span><br><br><span>#break after finding the professor</span><br><br><span>break</span><br><br><span> }</span><br><br><span> log local0. </span><span>"Matched \</span><span>$term</span><span>: </span><span>$term</span><span>. Exiting loop."</span><br><br><span>break</span><br><br><span> }</span><br><br><br><br><br><span> log local0. </span><span>"Matched \</span><span>$season</span><span>: </span><span>$season</span><span>. Exiting loop."</span><br><br><span>break</span><br><br><span> }</span><br><br><span> }</span><br><br><span> unset ::season_list</span><br><br><span> unset ::term_list</span><br><br><span> unset ::professor_list</span><br><br><span>} </span>

I’m not sure I follow all the logic you’re trying to achieve. Can you provide the goals of your iRule separate from the code, and if there is a full version of the iRule, can you post that (sanitized) in a gist on github or here if it’ll fit?

I’ve rewritten this completely and posted a new post with only the question I have about concatenation. Thanks.